[SPARK-39179][PYTHON][TESTS] Improve the test coverage for pyspark/shuffle.py #36701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
HyukjinKwon
reviewed
May 30, 2022
HyukjinKwon
reviewed
May 30, 2022
HyukjinKwon
reviewed
May 30, 2022
HyukjinKwon
reviewed
May 30, 2022
HyukjinKwon
reviewed
May 30, 2022
|
Hey, thanks for working on this. I will take another look in few more days. |
|
@HyukjinKwon Have done the changes as suggested. |
HyukjinKwon
reviewed
Jun 3, 2022
HyukjinKwon
reviewed
Jun 3, 2022
|
LGTM otherwise. |
HyukjinKwon
reviewed
Jun 3, 2022
HyukjinKwon
approved these changes
Jun 3, 2022
|
Thank you, @pralabhkumar and @HyukjinKwon . Merged to master for Apache Spark 3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR add test cases for shuffle.py
Why are the changes needed?
To cover corner test cases and increase coverage. This will increase the coverage of shuffle.py to close to 90%
Does this PR introduce any user-facing change?
No - test only
How was this patch tested?
CI in this PR should test it out