Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-39322][DOCS] Remove Experimental from spark.dynamicAllocation.shuffleTracking.enabled #36705

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 27, 2022

What changes were proposed in this pull request?

This PR aims to remove Experimental from spark.dynamicAllocation.shuffleTracking.enabled.

Why are the changes needed?

spark.dynamicAllocation.shuffleTracking.enabled was added at Apache Spark 3.0.0 and has been used with K8s resource manager.

Does this PR introduce any user-facing change?

No, this is a documentation only change.

How was this patch tested?

Manual.

@github-actions github-actions bot added the DOCS label May 27, 2022
@dongjoon-hyun
Copy link
Member Author

Could you review this, @attilapiros ?

@attilapiros
Copy link
Contributor

On Wednesday I can look into this.

@dongjoon-hyun
Copy link
Member Author

Oh, got it. Thank you for informing that. Thanks, @attilapiros .

Hi, @viirya . Could you review this, please?

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have corresponding tag in code that needs to be remove too?

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, does this target 3.4.0, right?

@dongjoon-hyun
Copy link
Member Author

I want to land it to branch-3.3 since the on-going RC fails, @viirya .

@dongjoon-hyun
Copy link
Member Author

AFAIK, this is the last one.

Do we have corresponding tag in code that needs to be remove too?

@viirya
Copy link
Member

viirya commented May 28, 2022

Oh, I see. As this was added since long before, looks okay to me.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya !

dongjoon-hyun added a commit that referenced this pull request May 28, 2022
…on.shuffleTracking.enabled`

### What changes were proposed in this pull request?

This PR aims to remove `Experimental` from `spark.dynamicAllocation.shuffleTracking.enabled`.

### Why are the changes needed?

`spark.dynamicAllocation.shuffleTracking.enabled` was added at Apache Spark 3.0.0 and has been used with K8s resource manager.

### Does this PR introduce _any_ user-facing change?

No, this is a documentation only change.

### How was this patch tested?

Manual.

Closes #36705 from dongjoon-hyun/SPARK-39322.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit fe85d79)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun deleted the SPARK-39322 branch May 28, 2022 01:01
dongjoon-hyun added a commit that referenced this pull request May 30, 2022
…ion and shuffle decommission

### What changes were proposed in this pull request?

This PR is a follow-up for #36705 to revise the missed log message change.

### Why are the changes needed?

Like the documentation, this PR updates the log message correspondingly.
- Lower log level to `INFO` from `WARN`
- Provide a specific message according to the configurations.

### Does this PR introduce _any_ user-facing change?

No. This is a log-message-only change.

### How was this patch tested?

Pass the CIs.

Closes #36725 from dongjoon-hyun/SPARK-39322-2.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun added a commit that referenced this pull request May 30, 2022
…ion and shuffle decommission

### What changes were proposed in this pull request?

This PR is a follow-up for #36705 to revise the missed log message change.

### Why are the changes needed?

Like the documentation, this PR updates the log message correspondingly.
- Lower log level to `INFO` from `WARN`
- Provide a specific message according to the configurations.

### Does this PR introduce _any_ user-facing change?

No. This is a log-message-only change.

### How was this patch tested?

Pass the CIs.

Closes #36725 from dongjoon-hyun/SPARK-39322-2.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit be2c8c0)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants