[SPARK-39372][R] Support R 4.2.0 #36758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Jun 3, 2022
| @@ -129,7 +129,7 @@ $env:PATH = "$env:HADOOP_HOME\bin;" + $env:PATH | |||
| Pop-Location | |||
|
|
|||
| # ========================== R | |||
| $rVer = "4.0.2" | |||
| $rVer = "4.2.0" | |||
| $rToolsVer = "4.0.2" | |||
There was a problem hiding this comment.
While the tests passed, it failed to download RTools 4.2.0. I reverted the RTools upgrade here for now.
HyukjinKwon
changed the title
HyukjinKwon
commented
Jun 3, 2022
| @@ -58,7 +58,12 @@ writeObject <- function(con, object, writeType = TRUE) { | |||
| # Checking types is needed here, since 'is.na' only handles atomic vectors, | |||
| # lists and pairlists | |||
| if (type %in% c("integer", "character", "logical", "double", "numeric")) { | |||
| if (is.na(object)) { | |||
| if (is.na(object[[1]])) { | |||
There was a problem hiding this comment.
R 4.1 and below:
Warning in if (is.na(c(1, 2))) print("abc") :
the condition has length > 1 and only the first element will be used
R 4.2+:
Error in if (is.na(c(1, 2))) print("abc") : the condition has length > 1
|
Tests should pass now .. |
HyukjinKwon
commented
Jun 3, 2022
| # Uses the first element for now to keep the behavior same as R before | ||
| # 4.2.0. This is wrong because we should differenciate c(NA) from a | ||
| # single NA as the former means array(null) and the latter means null | ||
| # in Spark SQL. However, it requires non-trivial comparison to distinguish |
There was a problem hiding this comment.
e.g.) we should check if the input is vector, list, array, etc, which is exactly being done at getSerdeType. However, this comparison here (up to my best knowledge) is a shortcut to avoid the overhead from getSerdeType. So, I just decided to leave it as is for now.
|
cc @felixcheung @shivaram @viirya too FYI |
dongjoon-hyun
approved these changes
Jun 3, 2022
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes:
Updates AppVeyor to use the latest R version 4.2.0.
Uses the correct way of checking if an object is a matrix:
is.matrix.After R 4.2.0,
class(upperBoundsOnCoefficients) != "matrix")fails:This fixes
spark.logitwhenlowerBoundsOnCoefficientsorupperBoundsOnCoefficientsis specified.Explicitly use the first element in
is.nacomparison. From R 4.2.0, it throws an exception as below:Previously it was a warning.
This fixes
createDataFrameoras.DataFramewhen the data type is a nested complex type.Why are the changes needed?
To support/test the latest R. R community tends to use the latest versions aggressively.
Does this PR introduce any user-facing change?
Yes, after this PR, we officially support R 4.2.0 in SparkR.
How was this patch tested?
CI in this PR should test it out.