[SPARK-39392][SQL][3.3] Refine ANSI error messages for try_* function hints #36792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hints Refine ANSI error messages and remove 'To return NULL instead' Improve error messaging for ANSI mode since the user may not even aware that query was returning NULLs. No Unit tests Closes apache#36780 from vli-databricks/SPARK-39392. Authored-by: Vitalii Li <vitalii.li@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
HyukjinKwon
approved these changes
Jun 8, 2022
|
Can one of the admins verify this patch? |
|
+1, LGTM. Merging to 3.3. |
MaxGekk
pushed a commit
that referenced
this pull request
Jun 8, 2022
… hints ### What changes were proposed in this pull request? Refine ANSI error messages and remove 'To return NULL instead'. This PR is a backport of #36780 from `master` ### Why are the changes needed? Improve error messaging for ANSI mode since the user may not even aware that query was returning NULLs. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests Closes #36792 from vli-databricks/SPARK-39392-3.3. Authored-by: Vitalii Li <vitalii.li@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refine ANSI error messages and remove 'To return NULL instead'.
This PR is a backport of #36780 from
masterWhy are the changes needed?
Improve error messaging for ANSI mode since the user may not even aware that query was returning NULLs.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests