-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-37670][FOLLOWUP][SQL][TESTS][3.2] Update TPCDS golden files #36815
Conversation
cc @maryannxue , @cloud-fan , @HyukjinKwon , @sunchao |
👍 |
Thank you, @HyukjinKwon ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thank you, @sunchao and @cloud-fan . |
|
Here is the summary.
However, the query plan structure itself looks identical. Only different ID is the root cause of failure here. |
Imagine that there is a global counter for CTE IDs, running a query along will have different IDs with running many queries. I think we need to regen the golden files with |
That golden files in |
Let me comment on the original PR. |
As an alternative, reverting PR is also under testing. |
Thank you everyone. This is closed according to @cloud-fan 's approach. |
What changes were proposed in this pull request?
This is a followup of #34929 to update TPCDS plan test golden file due to ID number changes.
Why are the changes needed?
Currently,
branch-3.2
is broken.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.