Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4822] Use sphinx tags for Python doc annotations #3685

Closed
wants to merge 2 commits into from

Conversation

Lewuathe
Copy link
Contributor

Modify python annotations for sphinx. There is no change to build process from.
https://github.com/apache/spark/blob/master/docs/README.md

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@jkbradley
Copy link
Member

@Lewuathe Thanks for the PR! As long as you're fixing those, would you mind fixing the 2 "DeveloperApi" tags in pyspark/mllib/feature.py and the 2 "WARN" tags in pyspark/sql.py?

@mengxr
Copy link
Contributor

mengxr commented Dec 17, 2014

ok to test

@mengxr
Copy link
Contributor

mengxr commented Dec 17, 2014

add to whitelist

@mengxr
Copy link
Contributor

mengxr commented Dec 17, 2014

test this please

@SparkQA
Copy link

SparkQA commented Dec 17, 2014

Test build #24561 has started for PR 3685 at commit 88a0fd9.

  • This patch merges cleanly.

@mengxr
Copy link
Contributor

mengxr commented Dec 18, 2014

LGTM. Waiting for Jenkins ...

@davies
Copy link
Contributor

davies commented Dec 18, 2014

LGTM, thanks!

@jkbradley
Copy link
Member

@Lewuathe I believe there are 2 more tags to fix (1 more DeveloperAPI and 1 more WARN tag) in those same files. (Thanks!)

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24561 has finished for PR 3685 at commit 88a0fd9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24561/
Test PASSed.

@jkbradley
Copy link
Member

Oops, I was wrong. LGTM
Thanks!

@mengxr
Copy link
Contributor

mengxr commented Dec 18, 2014

Merged into master. Thanks!

@asfgit asfgit closed this in 3cd5161 Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants