Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config #3688

Closed
wants to merge 1 commit into from

Conversation

aarondav
Copy link
Contributor

@SparkQA
Copy link

SparkQA commented Dec 13, 2014

Test build #24430 has started for PR 3688 at commit ebd2007.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 13, 2014

Test build #24430 has finished for PR 3688 at commit ebd2007.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24430/
Test FAILed.

@aarondav
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 14, 2014

Test build #24441 has started for PR 3688 at commit ebd2007.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 14, 2014

Test build #24441 has finished for PR 3688 at commit ebd2007.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24441/
Test FAILed.

@rxin
Copy link
Contributor

rxin commented Dec 16, 2014

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 16, 2014

Test build #24503 has started for PR 3688 at commit ebd2007.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 16, 2014

Test build #24503 has finished for PR 3688 at commit ebd2007.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24503/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Dec 16, 2014

LGTM.

@JoshRosen
Copy link
Contributor

LGTM, too, so I'm going to merge this into master (1.3.0) and branch-1.2 (1.2.1). Thanks!

asfgit pushed a commit that referenced this pull request Dec 19, 2014
…port config

This is used in NioBlockTransferService here:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/network/nio/NioBlockTransferService.scala#L66

Author: Aaron Davidson <aaron@databricks.com>

Closes #3688 from aarondav/SPARK-4837 and squashes the following commits:

ebd2007 [Aaron Davidson] [SPARK-4837] NettyBlockTransferService should use spark.blockManager.port config

(cherry picked from commit 105293a)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@asfgit asfgit closed this in 105293a Dec 19, 2014
@dizzy2
Copy link

dizzy2 commented Jan 12, 2015

this fix doesn't work when both executor and driver are running on the same machine (as they are trying to acquire the same port)

@aarondav
Copy link
Contributor Author

@dizzy2 Sorry, thought I responded earlier -- you are quite right. It should be a straightforward fix of adding a Utils.startServiceOnPort call to do the same incrementing we do elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants