Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-39530][SS][TESTS] Fix KafkaTestUtils to support IPv6 #36923

Closed
wants to merge 2 commits into from
Closed

[SPARK-39530][SS][TESTS] Fix KafkaTestUtils to support IPv6 #36923

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 20, 2022

What changes were proposed in this pull request?

This PR aims to fix KafkaTestUtils to support IPv6.

Why are the changes needed?

Currently, the test suite is using a hard-coded 127.0.0.1 like the following.

props.put("listeners", "SASL_PLAINTEXT://127.0.0.1:0")
props.put("advertised.listeners", "SASL_PLAINTEXT://127.0.0.1:0")

Does this PR introduce any user-facing change?

No. This is a test-only change.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-39530][SS][TESTS] Fix KafkaTestUtils to support IPv6 [SPARK-39530][SS][TESTS] Fix KafkaTestUtils to support IPv6 Jun 20, 2022
@github-actions github-actions bot added the SQL label Jun 20, 2022
@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !

@wangyum wangyum closed this in 550f5fe Jun 20, 2022
@wangyum
Copy link
Member

wangyum commented Jun 20, 2022

Merged to master.

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jun 20, 2022

Thank you, @wangyum and @HyukjinKwon !

@dongjoon-hyun dongjoon-hyun deleted the SPARK-39530 branch June 20, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants