Revert [SPARK-35223] Add IssueNavigationLink #37046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pan3793 We can mention the IDEA config in https://github.com/apache/spark-website/blob/asf-site/developer-tools.md also cc @viirya |
pan3793
approved these changes
Jul 1, 2022
srowen
approved these changes
Jul 1, 2022
|
thanks for review, merging to master! |
|
Got it. Thank you for the fix, @cloud-fan , @pan3793 , @srowen , @viirya . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
IDEA may re-generate the config files and it's annoying to manually exclude it from commit as the IDEA config file is under version control.
This PR removes the IDEA config files and ignores it in git. This is basically a revert of #32337
We can update the developer guideline about how to configure IDEA to show Github/JIRA links.
Why are the changes needed?
avoid git troubles.
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A