Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-39739][BUILD] Upgrade sbt to 1.7.0 #37151

Closed
wants to merge 4 commits into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Jul 11, 2022

What changes were proposed in this pull request?

This PR aims to upgrade sbt to 1.7.0.

Why are the changes needed?

This version updates scala version used by sbt to 2.12.16 and brings some bug fix, the release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions and AppVeyor build

@github-actions github-actions bot added the BUILD label Jul 11, 2022
@LuciferYang
Copy link
Contributor Author

Testing build first

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CI).

@LuciferYang
Copy link
Contributor Author

https://github.com/LuciferYang/spark/runs/7276570757
image

GA passed, but final status has not been updated

@LuciferYang
Copy link
Contributor Author

https://github.com/LuciferYang/spark/runs/7276570757 image

GA passed, but final status has not been updated

Yeah ~ All passed

@HyukjinKwon
Copy link
Member

Merged to master.

@LuciferYang
Copy link
Contributor Author

thanks @dongjoon-hyun @HyukjinKwon

@dongjoon-hyun
Copy link
Member

Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants