[SPARK-39807][PYTHON][PS] Respect Series.concat sort parameter to follow 1.4.3 behavior #37217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jul 18, 2022
|
Ready to go |
dongjoon-hyun
approved these changes
Jul 18, 2022
| @@ -334,19 +334,21 @@ def test_concat_index_axis(self): | |||
| ([psdf.reset_index(), psdf], [pdf.reset_index(), pdf]), | |||
| ([psdf, psdf[["C", "A"]]], [pdf, pdf[["C", "A"]]]), | |||
| ([psdf[["C", "A"]], psdf], [pdf[["C", "A"]], pdf]), | |||
| # only one Series | |||
| ([psdf, psdf["C"]], [pdf, pdf["C"]]), | |||
| ([psdf["C"], psdf], [pdf["C"], pdf]), | |||
There was a problem hiding this comment.
nit. I believe we can keep the test coverage to prevent a future regression at Series.concat.
There was a problem hiding this comment.
Thanks for reivew.
Yes, actually I also moved this to L347-L348, that means we will always check all case with latest pandas, to avoid regression. I will also bump infra pandas version to 1.4.3 after all fixes complete.
For pandas<1.4.3, these two cases will failed because pandas on Spark only follow the latest pandas behaviors, so I just skip them.
If you have any other concern, feel free to comments. Thanks!
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Respect Series.concat sort parameter when
num_series == 1to follow 1.4.3 behavior.Why are the changes needed?
In #36711, we follow the pandas 1.4.2 behaviors to respect Series.concat sort parameter except
num_series == 1case.In pandas 1.4.3, fix the issue pandas-dev/pandas#47127. The bug of
num_series == 1is also fixed, so we add this PR to follow panda 1.4.3 behavior.Does this PR introduce any user-facing change?
Yes, we already cover this case in:
https://github.com/apache/spark/blob/master/python/docs/source/migration_guide/pyspark_3.3_to_3.4.rst
How was this patch tested?