[WIP][SPARK-39794][PYTHON] Introduce parametric singleton for DataType #37219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xinrong-meng
commented
Jul 18, 2022
| if cls not in cls._instances: # type: ignore[attr-defined] | ||
| cls._instances[cls] = super( # type: ignore[misc, attr-defined] | ||
| def __call__(cls: Type[T], *args: Any, **kwargs: Any) -> T: # type: ignore[override] | ||
| key = (cls, args, str(kwargs)) |
There was a problem hiding this comment.
Strict matching of arguments is expected to reuse the same instance.
|
Can one of the admins verify this patch? |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
Is this still in progress? Just for confirming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce parametric singleton for DataType.
Why are the changes needed?
Otherwise, we will create a new DataType instance (with parameters in constructors, e.g.
Varchar,DecimalType) every time it's called.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.