[SPARK-39889][SQL] Use different error classes for numeric/interval divided by 0 #37313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @entong as well |
cloud-fan
approved these changes
Jul 27, 2022
MaxGekk
reviewed
Jul 27, 2022
| @@ -210,6 +210,12 @@ | |||
| "<message>" | |||
| ] | |||
| }, | |||
| "INTERVAL_DIVIDED_BY_ZERO" : { | |||
| "message" : [ | |||
| "Division by zero." | |||
There was a problem hiding this comment.
Doesn't try_divide help here? The TryDivide expression has some examples with intervals:
There was a problem hiding this comment.
Make sense. I have updated the message. Thanks!
MaxGekk
approved these changes
Jul 28, 2022
|
+1, LGTM. Merging to master (try to 3.3). |
|
@gengliangwang It conflicts w/ 3.3. It is up to you to backport it to branch-3.3. |
gengliangwang
added a commit
that referenced
this pull request
Aug 1, 2022
…rithmetic overflow ### What changes were proposed in this pull request? Similar with #37313, currently, when arithmetic overflow errors happen under ANSI mode, the error messages are like ``` [ARITHMETIC_OVERFLOW] long overflow. Use 'try_multiply' to tolerate overflow and return NULL instead. If necessary set spark.sql.ansi.enabled to "false" ``` The "(except for ANSI interval type)" part is confusing. We should remove it for the numeric arithmetic operations and have a new error class for the interval division error: `INTERVAL_ARITHMETIC_OVERFLOW` ### Why are the changes needed? For better error messages ### Does this PR introduce _any_ user-facing change? Yes, Use different error classes for arithmetic overflows of numeric/interval.. After changes, the error messages are simpler and more clear. ### How was this patch tested? UT Closes #37337 from gengliangwang/improveOverflowMsg. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
|
@MaxGekk Thanks, I will keep it on master branch for now. |
gengliangwang
added a commit
to gengliangwang/spark
that referenced
this pull request
Aug 2, 2022
…rithmetic overflow ### What changes were proposed in this pull request? Similar with apache#37313, currently, when arithmetic overflow errors happen under ANSI mode, the error messages are like ``` [ARITHMETIC_OVERFLOW] long overflow. Use 'try_multiply' to tolerate overflow and return NULL instead. If necessary set spark.sql.ansi.enabled to "false" ``` The "(except for ANSI interval type)" part is confusing. We should remove it for the numeric arithmetic operations and have a new error class for the interval division error: `INTERVAL_ARITHMETIC_OVERFLOW` ### Why are the changes needed? For better error messages ### Does this PR introduce _any_ user-facing change? Yes, Use different error classes for arithmetic overflows of numeric/interval.. After changes, the error messages are simpler and more clear. ### How was this patch tested? UT Closes apache#37337 from gengliangwang/improveOverflowMsg. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
gengliangwang
added a commit
that referenced
this pull request
Aug 2, 2022
…rithmetic overflow ### What changes were proposed in this pull request? Similar with #37313, currently, when arithmetic overflow errors happen under ANSI mode, the error messages are like ``` [ARITHMETIC_OVERFLOW] long overflow. Use 'try_multiply' to tolerate overflow and return NULL instead. If necessary set spark.sql.ansi.enabled to "false" ``` The "(except for ANSI interval type)" part is confusing. We should remove it for the numeric arithmetic operations and have a new error class for the interval division error: `INTERVAL_ARITHMETIC_OVERFLOW` ### Why are the changes needed? For better error messages ### Does this PR introduce _any_ user-facing change? Yes, Use different error classes for arithmetic overflows of numeric/interval.. After changes, the error messages are simpler and more clear. ### How was this patch tested? UT Closes #37374 from gengliangwang/SPARK-39917. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, when numbers are divided by 0 under ANSI mode, the error message is like
The "(except for ANSI interval type)" part is confusing. We should remove it for the numeric arithmetic operations and have a new error class for the interval division error: "INTERVAL_DIVIDED_BY_ZERO"
Why are the changes needed?
For better error messages
Does this PR introduce any user-facing change?
Yes, Use different error classes for numeric/interval divided by 0. After changes, the error messages are simpler and more clear.
How was this patch tested?
UT