Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-39899][SQL] Fix passing of message parameters to InvalidUDFClassException #37323

Closed
wants to merge 1 commit into from

Conversation

MaxGekk
Copy link
Member

@MaxGekk MaxGekk commented Jul 27, 2022

What changes were proposed in this pull request?

In the PR, I propose to pass messageParameters to AnalysisException from InvalidUDFClassException.

Also, I propose to replace checkErrorClass by checkError in the test "NO_HANDLER_FOR_UDAF: No handler for UDAF error" to check that the message parameters are passed correctly, and make the test independent from the message of the error class NO_HANDLER_FOR_UDAF.

Why are the changes needed?

To fix a bug and provide actual message parameters to users.

Does this PR introduce any user-facing change?

Yes. After the changes, users receive non-empty message parameters.

How was this patch tested?

By running the modified test suite:

$ build/sbt "sql/testOnly *QueryCompilationErrorsSuite"

@github-actions github-actions bot added the SQL label Jul 27, 2022
@MaxGekk MaxGekk changed the title [WIP][SQL] Fix passing of message parameters to InvalidUDFClassException [SPARK-39899][SQL] Fix passing of message parameters to InvalidUDFClassException Jul 27, 2022
@MaxGekk MaxGekk marked this pull request as ready for review July 27, 2022 18:59
@MaxGekk
Copy link
Member Author

MaxGekk commented Jul 27, 2022

@cloud-fan @srielau @AngersZhuuuu @ivoson Please, have a look at the PR since you touched InvalidUDFClassException

@MaxGekk
Copy link
Member Author

MaxGekk commented Jul 28, 2022

I think the test failure is not related to the changes:

Exception: java.util.concurrent.TimeoutException: Futures timed out after [2 minutes]
Failed to capture next expected output "Unclosed bracketed comment" within 2 minutes.

I re-ran the test locally.

@MaxGekk
Copy link
Member Author

MaxGekk commented Jul 28, 2022

Merging to master. Thank you, @cloud-fan for review.

@MaxGekk MaxGekk closed this in 378c207 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants