[SPARK-39857][SQL][3.3] V2ExpressionBuilder uses the wrong LiteralValue data type for In predicate #37324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ue data type for In predicate
There was a problem hiding this comment.
Hi, @huaxingao .
The PR description will be a commit message.
Please copy all the PR description to the backport PR and adds additional message like the following
back port #37271 to 3.3
| "`a.b`.cint", // two level nested field, and top level contains `dot` | ||
| "`a.b`.`c.int`", // two level nested field, and both levels contain `dot` | ||
| "a.b.cint" // three level nested field | ||
| )) |
There was a problem hiding this comment.
nit, to be clear, this is a backport of SPARK-39784 technically.
| test("translate simple expression") { attrInts.zip(attrStrs) | ||
| .foreach { case ((attrInt, intColName), (attrStr, strColName)) => | ||
| testTranslateFilter(EqualTo(attrInt, 1), | ||
| Some(new Predicate("=", Array(FieldReference(intColName), LiteralValue(1, IntegerType))))) |
There was a problem hiding this comment.
ditto. This is a backport of SPARK-39784 technically and is irrelevant to this PR's InSet contribution.
dongjoon-hyun
approved these changes
Jul 27, 2022
huaxingao
added a commit
that referenced
this pull request
Jul 28, 2022
…ue data type for In predicate ### What changes were proposed in this pull request? When building V2 In `Predicate` in `V2ExpressionBuilder`, `InSet.dataType` (which is BooleanType) is used to build the `LiteralValue`, `InSet.child.dataType `should be used instead. back port #37271 to 3.3 ### Why are the changes needed? bug fix ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? new test Closes #37324 from huaxingao/backport. Authored-by: huaxingao <huaxin_gao@apple.com> Signed-off-by: huaxingao <huaxin_gao@apple.com>
|
The GA status is unfinished, but the tests have been finished a while ago, so I will merge. |
|
Thank you very much @dongjoon-hyun for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When building V2 In
PredicateinV2ExpressionBuilder,InSet.dataType(which is BooleanType) is used to build theLiteralValue,InSet.child.dataTypeshould be used instead.back port #37271 to 3.3
Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no
How was this patch tested?
new test