Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode #37378

Closed
wants to merge 1 commit into from
Closed

[SPARK-39776][SQL][FOLLOW] Update UT of PlanStabilitySuite in ANSI mode #37378

wants to merge 1 commit into from

Conversation

AngersZhuuuu
Copy link
Contributor

What changes were proposed in this pull request?

The current verbose string of LogicalPlan didn't contain join type, we should add this

(10) BroadcastHashJoin [codegen id : 4]
Left keys [1]: [ws_sold_date_sk#7]
Right keys [1]: [d_date_sk#9]
Join type: Inner
Join condition: None

Why are the changes needed?

Add missed join type in verbose plan

Does this PR introduce any user-facing change?

User can see join type in verbose plan string

How was this patch tested?

Existed UT

@AngersZhuuuu
Copy link
Contributor Author

ping @HyukjinKwon @cloud-fan

@github-actions github-actions bot added the SQL label Aug 2, 2022
@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
2 participants
@AngersZhuuuu @HyukjinKwon