Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-40073][INFRA][BUILD][CORE][SQL][AVRO][PYTHON] Replace external/{moduleName} with connector/{moduleName} #37512

Closed
wants to merge 1 commit into from
Closed

[SPARK-40073][INFRA][BUILD][CORE][SQL][AVRO][PYTHON] Replace external/{moduleName} with connector/{moduleName} #37512

wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Aug 14, 2022 •
edited

What changes were proposed in this pull request?

SPARK-38569 rename external top level dir to connector, but the use of external/${moduleName} still remains in Spark, this pr replaces them all with connector/{moduleName}

Why are the changes needed?

Should use connector/{moduleName} instead of `external/${moduleName}

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

@LuciferYang LuciferYang changed the title [SPARK-40073][DOCS] Replace external/${moduleName} with connector/${moduleName} [SPARK-40073][DOCS] Replace external/{moduleName} with connector/{moduleName} Aug 14, 2022
@LuciferYang LuciferYang changed the title [SPARK-40073][DOCS] Replace external/{moduleName} with connector/{moduleName} [SPARK-40073][INFRA] Replace external/{moduleName} with connector/{moduleName} Aug 14, 2022
@LuciferYang LuciferYang changed the title [SPARK-40073][INFRA] Replace external/{moduleName} with connector/{moduleName} [SPARK-40073][INFRA][BUILD][CORE][SQL][AVRO][PYTHON] Replace external/{moduleName} with connector/{moduleName} Aug 14, 2022
@LuciferYang
Copy link
Contributor Author

cc @HyukjinKwon

@LuciferYang
Copy link
Contributor Author 

external/avro
external/docker
external/docker-integration-tests
external/kafka-0-10
external/kafka-0-10-assembly
external/kafka-0-10-sql
external/kafka-0-10-token-provider
external/kinesis-asl
external/kinesis-asl-assembly
external/spark-ganglia-lgpl

manually searched the above keywords in IDE and replaced them

dongjoon-hyun
dongjoon-hyun reviewed Aug 14, 2022
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @alkis and @cloud-fan

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in c7c03f1 Aug 15, 2022
@LuciferYang
Copy link
Contributor Author

thanks @cloud-fan @dongjoon-hyun @HyukjinKwon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun left review comments

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
AVRO BUILD CORE INFRA PYTHON SQL
Projects
None yet
Milestone
No milestone
4 participants
@LuciferYang @cloud-fan @HyukjinKwon @dongjoon-hyun