Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-40116][R][INFRA] Remove Arrow in AppVeyor for now #37546

Closed
wants to merge 2 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Aug 17, 2022

What changes were proposed in this pull request?

This PR proposes to remoove the Arrow in AppVeyor for now to recover the build.

Why are the changes needed?

SparkR does not support Arrow 9.0.0 (SPARK-40114) so the tests fail (https://ci.appveyor.com/project/HyukjinKwon/spark/builds/44490387)

Should recover the tests first because it looks it's going to take a while to add the Arrow 9.0.0 support.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

CI in this PR should test it out.

@github-actions github-actions bot added the INFRA label Aug 17, 2022
@HyukjinKwon
Copy link
Member Author

Okay, seems like manual installation doesn't work due to the compliation (since R package only maintains binaries for latest versions).

@HyukjinKwon
Copy link
Member Author

Let me remove it for now (so it can skip the test)

@HyukjinKwon
Copy link
Member Author

Merged to master.

Missing Arrow is already tested in the previous commit.

I will take a look for Arrow 9.0.0 soon.

@HyukjinKwon HyukjinKwon changed the title [SPARK-40116][R][INFRA] Pin Arrow version to 8.0.0 in AppVeyor [SPARK-40116][R][INFRA] Remove Arrow in AppVeyor for now Aug 17, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @HyukjinKwon .

cc @LuciferYang because this is related to SPARK-39913 too

@dongjoon-hyun
Copy link
Member

BTW, it must be due to that I missed that GitHub Action SparkR tests used pre-built old SparkR image on SPARK-39913.

sparkSQL_arrow: 
SparkSQL Arrow optimization: .................

@LuciferYang
Copy link
Contributor

BTW, it must be due to that I missed that GitHub Action SparkR tests used pre-built old SparkR image on SPARK-39913.

sparkSQL_arrow: 
SparkSQL Arrow optimization: .................

Is this why GA can test successfully?

@LuciferYang
Copy link
Contributor

Should we revert SPARK-39913

@HyukjinKwon
Copy link
Member Author

Jvm arrow 9.0.0 is fine. It's a problem in R library of Arrow. I'll make a fix hopefully soon anyway

@HyukjinKwon HyukjinKwon deleted the SPARK-40116 branch January 15, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants