Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-40114][R] Arrow 9.0.0 support with SparkR #37553

Closed
wants to merge 2 commits into from

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Aug 17, 2022

What changes were proposed in this pull request?

This PR switches the deprecated API write_arrow(..., raw()) to use write_to_raw. This is exactly the same behaviour/replacement.

See also:

Why are the changes needed?

write_arrow is removed out from Arrow 9.0.0 in R Array library.

Note that write_to_raw has existed from Arrow 0.17.0 so I expect this is a safe change.

Does this PR introduce any user-facing change?

Yes, users can use R Arrow 9.0.0.

How was this patch tested?

Ci in this PR should test it out.

@HyukjinKwon HyukjinKwon marked this pull request as draft August 17, 2022 11:04
@HyukjinKwon HyukjinKwon changed the title [SPARK-40114][R] Arrow 9.0.0 support with SparkR [WIP][SPARK-40114][R] Arrow 9.0.0 support with SparkR Aug 17, 2022
@HyukjinKwon HyukjinKwon marked this pull request as ready for review August 17, 2022 11:57
@HyukjinKwon HyukjinKwon changed the title [WIP][SPARK-40114][R] Arrow 9.0.0 support with SparkR [SPARK-40114][R] Arrow 9.0.0 support with SparkR Aug 17, 2022
@HyukjinKwon
Copy link
Member Author

cc @LuciferYang @dongjoon-hyun FYI!

Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM, Thanks @HyukjinKwon

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @HyukjinKwon and @LuciferYang .
Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants