[SPARK-40153][SQL] Unify resolve functions and table-valued functions #37586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan |
allisonwang-db
changed the title
cloud-fan
reviewed
Aug 25, 2022
| @@ -2088,12 +2087,14 @@ class Analyzer(override val catalogManager: CatalogManager) | |||
| /** | |||
| * Replaces [[UnresolvedFunc]]s with concrete [[LogicalPlan]]s. | |||
| * Replaces [[UnresolvedFunction]]s with concrete [[Expression]]s. | |||
| * Replaces [[UnresolvedTableValuedFunction]]s with concrete [[LogicalPlan]]s. | |||
There was a problem hiding this comment.
seems we are updating the comments, let's list UnresolvedGenerator as well.
cloud-fan
approved these changes
Aug 25, 2022
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR merges the analyzer rule
ResolveTableValuedFunctionsintoResolveFunctions.Why are the changes needed?
Unify the code logic and make resolve scalar and table-valued functions consistent.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests.