[SPARK-40165][BUILD] Update test plugins to latest versions #37598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged to master |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 22, 2022
### What changes were proposed in this pull request? This reverts commit 3ed382f. #37598 ### Why are the changes needed? This patch cause the error like: ``` [error] /home/runner/work/spark/spark/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HttpAuthUtils.java:36:1: error: package org.apache.http.protocol does not exist [error] import org.apache.http.protocol.BasicHttpContext; [error] ^ [error] /home/runner/work/spark/spark/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HttpAuthUtils.java:156:1: error: cannot find symbol [error] private final HttpContext httpContext; [error] ^ symbol: class HttpContext [error] location: class HttpKerberosClientAction [error] 3 errors ``` The old cache + new pom passed. Then, cache is outdate, the real error happened. According investigation, I found that this 3ed382f should be the real first bad commit. I just found this job are using cache: https://github.com/panbingkun/spark/runs/7938361118?check_suite_focus=true With old cache + new: passed. (that's the reason that the original PR passed) Without any cache + new pom: failed. (that's reason that CI break) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed, especially, 2.13 passed Closes #37618 from Yikun/xxxx1. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
This is reverted via b619212 in order to recover CI. |
|
Ah shoot, it failed? OK, weird |
|
Ya, it was a trick situation~ There exists some investigation result on the reverting PR. |
|
I will investigate the root cause for the failure carefully. |
Yikun
pushed a commit
to Yikun/spark
that referenced
this pull request
Aug 23, 2022
### What changes were proposed in this pull request? This PR test updates plugins to latest versions. ### Why are the changes needed? This brings improvment & bug fixes like the following: - 1.scalacheck (from 1.15.4 to 1.16.0) https://github.com/typelevel/scalacheck/releases typelevel/scalacheck@1.15.4...v1.16.0 typelevel/scalacheck@2ae1be5 typelevel/scalacheck@902121e - 2.maven-surefire-plugin (from 3.0.0-M5 to 3.0.0-M7) https://github.com/apache/maven-surefire/releases apache/maven-surefire@surefire-3.0.0-M5...surefire-3.0.0-M7 - 3.maven-dependency-plugin (from 3.1.1 to 3.3.0) apache/maven-dependency-plugin@maven-dependency-plugin-3.1.1...maven-dependency-plugin-3.3.0 apache/maven-dependency-plugin@9646b0e ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA and testing with the existing code. Closes apache#37598 from panbingkun/upgrade_maven-dependency-plugin. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
LuciferYang
reviewed
Aug 23, 2022
| @@ -2932,7 +2932,7 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <version>3.0.0-M5</version> | |||
| <version>3.0.0-M7</version> | |||
There was a problem hiding this comment.
@panbingkun There is a behavioral difference between 3.0.0-M5 and 3.0.0-M7:
mvn clean install -pl core -Dtest=none pass with 3.0.0-M5, but failed with 3.0.0-M7` as follows:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M7:test (default-test) on project spark-core_2.12: No tests matching pattern "none" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
seems that configuration <failIfNoSpecifiedTests>false</failIfNoSpecifiedTests> needs to be added
srowen
pushed a commit
that referenced
this pull request
Oct 1, 2022
### What changes were proposed in this pull request? This PR test updates plugins to latest versions. PS: The PR following #37598 ### Why are the changes needed? This brings improvment & bug fixes like the following: - 1.scalacheck (from 1.16.0 to 1.17.0) https://github.com/typelevel/scalacheck/releases typelevel/scalacheck@v1.16.0...v1.17.0 <img width="693" alt="image" src="https://user-images.githubusercontent.com/15246973/193226401-e5019a6f-d7b3-4b83-b488-e6e8f4ab613d.png"> - 2.maven-surefire-plugin (from 3.0.0-M5 to 3.0.0-M7) https://github.com/apache/maven-surefire/releases apache/maven-surefire@surefire-3.0.0-M5...surefire-3.0.0-M7 - 3.maven-dependency-plugin (from 3.1.1 to 3.3.0) apache/maven-dependency-plugin@maven-dependency-plugin-3.1.1...maven-dependency-plugin-3.3.0 apache/maven-dependency-plugin@9646b0e ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA and testing with the existing code. Closes #38054 from panbingkun/SPARK-40165. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR test updates plugins to latest versions.
Why are the changes needed?
This brings improvment & bug fixes like the following:
1.scalacheck (from 1.15.4 to 1.16.0)
https://github.com/typelevel/scalacheck/releases
typelevel/scalacheck@1.15.4...v1.16.0
typelevel/scalacheck@2ae1be5
typelevel/scalacheck@902121e
2.maven-surefire-plugin (from 3.0.0-M5 to 3.0.0-M7)
https://github.com/apache/maven-surefire/releases
apache/maven-surefire@surefire-3.0.0-M5...surefire-3.0.0-M7
3.maven-dependency-plugin (from 3.1.1 to 3.3.0)
apache/maven-dependency-plugin@maven-dependency-plugin-3.1.1...maven-dependency-plugin-3.3.0
apache/maven-dependency-plugin@9646b0e
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA and testing with the existing code.