[SPARK-40219][SQL] Resolved view logical plan should hold the schema to avoid redundant lookup #37658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems many test failures. |
|
@viirya tests all passed now |
|
Thanks @cloud-fan. I'll review this today. |
viirya
reviewed
Aug 30, 2022
| } | ||
| tmpView | ||
| } | ||
|
|
||
| /** | ||
| * Resolves relations to `ResolvedTable` or `ResolvedView`. This is for resolving DDL and |
There was a problem hiding this comment.
ResolvedView -> ResolvedTempView and ResolvedPersistentView
viirya
approved these changes
Aug 30, 2022
huaxingao
approved these changes
Aug 31, 2022
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
CatalogImpl, we need to look up the view again to get the schema, asResolvedViewonly contains the view identifier. This PR fix this issue by refactoring theResolvedView:ResolvedPersistentViewandResolvedTempViewResolvedPersistentViewholds the catalog, to matchResolvedTable.This PR also cleans up the temp view related methods in
SessionCatalog:Methods that interact with temp views onlyWhy are the changes needed?
code cleanup and avoid redundant view lookup
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests