Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4928][SQL] Fix: Operator '>,<,>=,<=' with decimal between different precision report error #3767

Closed
wants to merge 4 commits into from
Closed

[SPARK-4928][SQL] Fix: Operator '>,<,>=,<=' with decimal between different precision report error #3767

wants to merge 4 commits into from

Conversation

guowei2
Copy link
Contributor

@guowei2 guowei2 commented Dec 23, 2014

case operator with decimal between different precision, we need change them to unlimited

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@liancheng
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24729 has started for PR 3767 at commit b4985a2.

  • This patch merges cleanly.

liancheng
liancheng reviewed Dec 23, 2014
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
@@ -361,6 +361,21 @@ trait HiveTypeCoercion {
DecimalType(min(p1 - s1, p2 - s2) + max(s1, s2), max(s1, s2))
)

// Cast is no need for logical operator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: "no need" => "not needed"

@liancheng
Copy link
Contributor

Could you please add a test case? Thanks!

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24729 has finished for PR 3767 at commit b4985a2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24729/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24733 has started for PR 3767 at commit 3214e0a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24736 has started for PR 3767 at commit c6a6e3e.

  • This patch merges cleanly.

@liancheng
Copy link
Contributor

LGTM as long as Jenkins says yes. Thanks for working on this!

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24733 has finished for PR 3767 at commit 3214e0a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24733/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24736 has finished for PR 3767 at commit c6a6e3e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24736/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks! Merged to master.

@asfgit asfgit closed this in a75dd83 Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@guowei2 @AmplabJenkins @liancheng @SparkQA @marmbrus