Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4920][UI] add version on master and worker page for standalone mode #3769

Closed

Conversation

liyezhang556520
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Dec 23, 2014

Test build #24722 has finished for PR 3769 at commit 3bb7e0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

Here's a screenshot of what this looks like on various pages:

Master:

image

Log viewer:

image

Worker:

image

Before:

Here's what it looked like before:

image

I think the extra horizontal space looks a little odd, but that's only because I'm using a SNAPSHOT version; it should look fine for releases. Therefore, I'm inclined to merge this unless anyone has objections.

@liyezhang556520
Copy link
Contributor Author

@JoshRosen , is this PR ready to merge?

@JoshRosen
Copy link
Contributor

This looks good to me, so I'll merge it. Thanks for the reminder.

Before I merge this, though, I'm going to hotfix the package-level SPARK_VERSION into the backport branches, since I accidentally broke those builds the last time I merged a fix using org.apache.spark.SPARK_VERSION.

@JoshRosen
Copy link
Contributor

I've made the SPARK_VERSION change in the maintenance branches, so I'm now going to merge this into master (1.3.0), branch-1.2 (1.2.1), branch-1.1 (1.1.2), and branch-1.0 (1.0.3). Thanks!

@asfgit asfgit closed this in 9077e72 Dec 30, 2014
asfgit pushed a commit that referenced this pull request Dec 30, 2014
… mode

Author: Zhang, Liye <liye.zhang@intel.com>

Closes #3769 from liyezhang556520/spark-4920_WebVersion and squashes the following commits:

3bb7e0d [Zhang, Liye] add version on master and worker page

(cherry picked from commit 9077e72)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@JoshRosen
Copy link
Contributor

Actually, it looks like there are other patches that need to be cherry-picked before this can be pulled into branch-1.1 (1.1.2) and branch-1.0 (1.0.3); I'll tag this in JIRA for followup and handle it myself.

@liyezhang556520 liyezhang556520 deleted the spark-4920_WebVersion branch August 26, 2015 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants