[SPARK-40056][BUILD] Upgrade mvn-scalafmt from 1.0.4 to 1.1.1640084764.9f463a9 #37727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Aug 30, 2022
HyukjinKwon
reviewed
Aug 30, 2022
|
cc @srowen FYI |
panbingkun
commented
Aug 30, 2022
panbingkun
commented
Aug 30, 2022
panbingkun
commented
Aug 30, 2022
panbingkun
commented
Aug 30, 2022
panbingkun
commented
Aug 30, 2022
panbingkun
commented
Aug 30, 2022
srowen
approved these changes
Aug 30, 2022
HyukjinKwon
approved these changes
Aug 30, 2022
|
Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 12, 2024
…8` & `scalafmt` to `3.8.0` ### What changes were proposed in this pull request? The pr aims to upgrade `mvn-scalafmt` from `1.1.1640084764.9f463a9` to `1.1.1684076452.9f83818`. ### Why are the changes needed? - mvn-scalafmt The last `mvn-scalafmt` upgrade occurred 1 year ago, #37727 The latest version of `mvn-scalafmt` release notes: https://github.com/SimonJPegg/mvn_scalafmt/releases/tag/2.13-1.1.1684076452.9f83818 - scalafmt The latest version of `scalafmt` release notes: https://github.com/scalameta/scalafmt/releases/tag/v3.8.0 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test. ``` ./build/mvn scalafmt:format -Dscalafmt.skip=false ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2.216 s [INFO] Finished at: 2024-03-10T20:30:11+08:00 [INFO] ------------------------------------------------------------------------ ``` ``` ./dev/scalafmt ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:56 min [INFO] Finished at: 2024-03-10T20:19:46+08:00 [INFO] ------------------------------------------------------------------------ ``` - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45452 from panbingkun/SPARK-47335. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
jpcorreia99
pushed a commit
to jpcorreia99/spark
that referenced
this pull request
Mar 12, 2024
…8` & `scalafmt` to `3.8.0` ### What changes were proposed in this pull request? The pr aims to upgrade `mvn-scalafmt` from `1.1.1640084764.9f463a9` to `1.1.1684076452.9f83818`. ### Why are the changes needed? - mvn-scalafmt The last `mvn-scalafmt` upgrade occurred 1 year ago, apache#37727 The latest version of `mvn-scalafmt` release notes: https://github.com/SimonJPegg/mvn_scalafmt/releases/tag/2.13-1.1.1684076452.9f83818 - scalafmt The latest version of `scalafmt` release notes: https://github.com/scalameta/scalafmt/releases/tag/v3.8.0 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test. ``` ./build/mvn scalafmt:format -Dscalafmt.skip=false ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2.216 s [INFO] Finished at: 2024-03-10T20:30:11+08:00 [INFO] ------------------------------------------------------------------------ ``` ``` ./dev/scalafmt ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:56 min [INFO] Finished at: 2024-03-10T20:19:46+08:00 [INFO] ------------------------------------------------------------------------ ``` - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45452 from panbingkun/SPARK-47335. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
…8` & `scalafmt` to `3.8.0` ### What changes were proposed in this pull request? The pr aims to upgrade `mvn-scalafmt` from `1.1.1640084764.9f463a9` to `1.1.1684076452.9f83818`. ### Why are the changes needed? - mvn-scalafmt The last `mvn-scalafmt` upgrade occurred 1 year ago, apache#37727 The latest version of `mvn-scalafmt` release notes: https://github.com/SimonJPegg/mvn_scalafmt/releases/tag/2.13-1.1.1684076452.9f83818 - scalafmt The latest version of `scalafmt` release notes: https://github.com/scalameta/scalafmt/releases/tag/v3.8.0 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - Manually test. ``` ./build/mvn scalafmt:format -Dscalafmt.skip=false ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 2.216 s [INFO] Finished at: 2024-03-10T20:30:11+08:00 [INFO] ------------------------------------------------------------------------ ``` ``` ./dev/scalafmt ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:56 min [INFO] Finished at: 2024-03-10T20:19:46+08:00 [INFO] ------------------------------------------------------------------------ ``` - Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45452 from panbingkun/SPARK-47335. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade mvn-scalafmt from 1.0.4 to 1.1.1640084764.9f463a9
PS:
Why are the changes needed?
The last upgrade occurred 2 year ago.
maven repo version: https://mvnrepository.com/artifact/org.antipathy/mvn-scalafmt
The new version specifically update the following issues:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA & Manual test