[SPARK-40291][SQL] Improve the message for column not in group by clause error #37742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linhongliu-db
force-pushed
the
SPARK-40291
branch
from
0d92e87
to
b3a0e76
Compare
|
cc @cloud-fan |
MaxGekk
requested changes
Sep 1, 2022
| @@ -65,6 +65,12 @@ | |||
| ], | |||
| "sqlState" : "22005" | |||
| }, | |||
| "COLUMN_NOT_IN_GROUP_BY_CLAUSE" : { | |||
| "message" : [ | |||
| "expression '<expression>' is neither present in the group by, nor is it an aggregate function. Add to group by or wrap in first() (or first_value) if you don't care which value you get." | |||
There was a problem hiding this comment.
Please, remove '' around and use toSQLExpr(), and first() should be quoted by back ticks.
| def columnNotInGroupByClauseError(expression: Expression): Throwable = { | ||
| new AnalysisException( | ||
| errorClass = "COLUMN_NOT_IN_GROUP_BY_CLAUSE", | ||
| messageParameters = Array(expression.sql) |
There was a problem hiding this comment.
expression.sql -> toSQLExpr(expression)
|
@MaxGekk Thanks for reviewing! I updated the PR |
MaxGekk
reviewed
Sep 2, 2022
Comment on lines
900
to
902
| assert( | ||
| e.contains("COLUMN_NOT_IN_GROUP_BY_CLAUSE") && | ||
| e.contains("\"c1\"")) |
There was a problem hiding this comment.
Could you use checkError(), please. See the check above.
Co-authored-by: Maxim Gekk <max.gekk@gmail.com>
MaxGekk
approved these changes
Sep 7, 2022
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the message for columns not in group by clause error
Why are the changes needed?
Use the new error class framework for columns not in group by clause error
Does this PR introduce any user-facing change?
Yes, adding error class
How was this patch tested?
UT