[SPARK-40420][SQL] Sort error message parameters by names in the JSON formats #37875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
|
@cloud-fan @gengliangwang @srielau @anchovYu @HyukjinKwon Could you review this PR, please. I have faced to an issue while slightly changing the implementation in #37871 - the output in the JSON formats is not stable and depends on Map's impls (actually Scala's map cannot guarantee the order obviously). |
|
The failure Run / Scala 2.13 build with SBT is not related to the PR but I will re-trigger it just in case. |
cloud-fan
approved these changes
Sep 14, 2022
|
Run / Scala 2.13 build with SBT passed successfully. Merging to master. Thank you, @cloud-fan for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to sort error message parameters in the MINIMAL and STANDARD formats (JSON formats) by parameter names.
Why are the changes needed?
To make the output in JSON format stable.
Does this PR introduce any user-facing change?
Yes.
How was this patch tested?
By running the modified test suites: