[Minor] Fix a typo of type parameter in JavaUtils.scala #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,7 @@ private[spark] object JavaUtils { | |||
| prev match { | |||
| case Some(k) => | |||
| underlying match { | |||
| case mm: mutable.Map[a, _] => | |||
| case mm: mutable.Map[_, _] => | |||
There was a problem hiding this comment.
Should this really be A to express the relation to the generic bound? although underlying must already have keys of type A already. It just looks like that was the intent.
There was a problem hiding this comment.
I thought it should be A but the type parameter at the position is no mean because the erasure removes type information at the time of compile.
Even though, should we place A for readability?
|
Test build #24780 has finished for PR 3789 at commit
|
|
Test build #24796 has finished for PR 3789 at commit
|
|
Merging in master. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JavaUtils.scala, thare is a typo of type parameter. In addition, the type information is removed at the time of compile by erasure.
This issue is really minor so I don't file in JIRA.