[SPARK-40436][BUILD] Upgrade Scala to 2.12.17 #37892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test first |
|
wait ghik/silencer#75 and new version of silencer |
86571e9 bump silencer to 1.7.10 |
|
All test passed, issues with release-notes tags as follows: Waiting for the official release notes |
dongjoon-hyun
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
+1, LGTM. Thank you, @LuciferYang and @srowen .
Merged to master for Apache Spark 3.4.0.
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Sep 20, 2022
### What changes were proposed in this pull request? This PR aims to upgrade Scala to 2.12.17 - https://www.scala-lang.org/news/2.12.17 ### Why are the changes needed? The main [change](https://github.com/scala/scala/pulls?q=is%3Apr+sort%3Aupdated-desc+milestone%3A2.12.17+is%3Amerged+label%3Arelease-notes) fo this version as follows: - scala/scala#10109 - scala/scala#10075 - scala/scala#10108 - scala/scala#10045 - scala/scala#10063 - scala/scala#10042 - scala/scala#10040 - scala/scala#10095 ### Does this PR introduce _any_ user-facing change? Yes, this is a Scala version change. ### How was this patch tested? Existing Test Closes apache#37892 from LuciferYang/SPARK-40436. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This was referenced Sep 28, 2022
pan3793
pushed a commit
to apache/kyuubi
that referenced
this pull request
Sep 29, 2022
### _Why are the changes needed?_ Close #3573. This PR aims to upgrade scala to 2.12.17 1. [Scala 2.12.17](https://www.scala-lang.org/news/2.12.17) is available currently, This version has notable changes affecting compatibility, for more details see [release note](https://github.com/scala/scala/releases/tag/v2.12.17). 2. Spark was [upgraded](apache/spark#37892) to this version half a month ago. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #3574 from Yikf/bump-scala. Closes #3573 51521d8 [Yikf] bump scala from 2.12.16 to 2.12.17 Authored-by: Yikf <yikaifei1@gmail.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade Scala to 2.12.17
Why are the changes needed?
The main change fo this version as follows:
-release; deprecate-targetscala/scala#10109usingin method signature (to aid cross-building with Scala 3) scala/scala#10075-Xsource:2.13, warn about changed precedence in imports scala/scala#10095Does this PR introduce any user-facing change?
Yes, this is a Scala version change.
How was this patch tested?
Existing Test