Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4959] [SQL] Attributes are case sensitive when using a select query from a projection #3796

Closed
wants to merge 1 commit into from
Closed

[SPARK-4959] [SQL] Attributes are case sensitive when using a select query from a projection #3796

wants to merge 1 commit into from

Conversation

chenghao-intel
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Dec 25, 2014

Test build #24812 has started for PR 3796 at commit 62a7a10.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 25, 2014

Test build #24812 has finished for PR 3796 at commit 62a7a10.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24812/
Test PASSed.

@cloud-fan
Copy link
Contributor

Looks like using AttributeMap can avoid creating many AttributeEquals during map building and searching. Did I miss something here? I'm not so familiar with optimize phase :)

@chenghao-intel
Copy link
Contributor Author

Yes, you're right, thank you. I've updated the code.

@SparkQA
Copy link

SparkQA commented Dec 26, 2014

Test build #24831 has started for PR 3796 at commit 3ec08f8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 26, 2014

Test build #24831 has finished for PR 3796 at commit 3ec08f8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24831/
Test PASSed.

@marmbrus
Copy link
Contributor

Thanks for fixing this! Merged to master and branch-1.2.

@asfgit asfgit closed this in 5595eaa Dec 30, 2014
@marmbrus
Copy link
Contributor

Actually did not apply cleanly to branch-1.2. Only merged to master. We can consider a special backport.

@chenghao-intel chenghao-intel mentioned this pull request Jan 13, 2015
Closed
asfgit pushed a commit that referenced this pull request Jan 21, 2015
@chenghao-intel @rxin
[SPARK-4959][SQL] Attributes are case sensitive when using a select q…
92c238c 
…uery from a projection(Backport to Spark-1.2)

This is a follow up of #3796 , which can not be merged back to Spark-1.2. Manually merge it.

Author: Cheng Hao <hao.cheng@intel.com>

Closes #4013 from chenghao-intel/spark_4959_backport and squashes the following commits:

1f6c93d [Cheng Hao] backport to Spark-1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@chenghao-intel @SparkQA @AmplabJenkins @cloud-fan @marmbrus