Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-40434][SS][PYTHON][FOLLOWUP] Address review comments #37964

Closed
wants to merge 2 commits into from

Conversation

HeartSaVioR
Copy link
Contributor

What changes were proposed in this pull request?

This PR addresses the review comments from the last round of review from @HyukjinKwon in #37893.

Why are the changes needed?

Better documentation and removing unnecessary code.

Does this PR introduce any user-facing change?

Slight documentation change.

How was this patch tested?

N/A

@HeartSaVioR
Copy link
Contributor Author

cc. @HyukjinKwon

The size of each DataFrame in both the input and output can be arbitrary. The number of
DataFrames in both the input and output can also be arbitrary.
The size of each `pandas.DataFrame` in both the input and output can be arbitrary. The
number `pandas.DataFrame` in both the input and output can also be arbitrary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

number -> number of?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HeartSaVioR
Copy link
Contributor Author

Thanks! Merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants