[SPARK-40574][DOCS] Enhance DROP TABLE documentation #38011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
+1, LGTM. Thank you, @wangyum , @itholic , @zhengruifeng .
Merged to master/3.3/3.2.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 27, 2022
### What changes were proposed in this pull request?
This PR adds `PURGE` in `DROP TABLE` documentation.
Related documentation and code:
1. Hive `DROP TABLE` documentation:
https://cwiki.apache.org/confluence/display/hive/languagemanual+ddl
<img width="877" alt="image" src="https://user-images.githubusercontent.com/5399861/192425153-63ac5373-dd34-48b3-864c-324cf5ba5db9.png">
2. Hive code:
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L1185-L1209
3. Spark code:
https://github.com/apache/spark/blob/v3.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala#L1317-L1327
### Why are the changes needed?
Enhance documentation.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
manual test.
Closes #38011 from wangyum/SPARK-40574.
Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 11eefc8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 27, 2022
### What changes were proposed in this pull request?
This PR adds `PURGE` in `DROP TABLE` documentation.
Related documentation and code:
1. Hive `DROP TABLE` documentation:
https://cwiki.apache.org/confluence/display/hive/languagemanual+ddl
<img width="877" alt="image" src="https://user-images.githubusercontent.com/5399861/192425153-63ac5373-dd34-48b3-864c-324cf5ba5db9.png">
2. Hive code:
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L1185-L1209
3. Spark code:
https://github.com/apache/spark/blob/v3.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala#L1317-L1327
### Why are the changes needed?
Enhance documentation.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
manual test.
Closes #38011 from wangyum/SPARK-40574.
Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 11eefc8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
### What changes were proposed in this pull request?
This PR adds `PURGE` in `DROP TABLE` documentation.
Related documentation and code:
1. Hive `DROP TABLE` documentation:
https://cwiki.apache.org/confluence/display/hive/languagemanual+ddl
<img width="877" alt="image" src="https://user-images.githubusercontent.com/5399861/192425153-63ac5373-dd34-48b3-864c-324cf5ba5db9.png">
2. Hive code:
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L1185-L1209
3. Spark code:
https://github.com/apache/spark/blob/v3.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala#L1317-L1327
### Why are the changes needed?
Enhance documentation.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
manual test.
Closes apache#38011 from wangyum/SPARK-40574.
Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 11eefc8)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds
PURGEinDROP TABLEdocumentation.Related documentation and code:
DROP TABLEdocumentation:https://cwiki.apache.org/confluence/display/hive/languagemanual+ddl
https://github.com/apache/hive/blob/rel/release-2.3.9/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L1185-L1209
https://github.com/apache/spark/blob/v3.3.0/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala#L1317-L1327
Why are the changes needed?
Enhance documentation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
manual test.