[SPARK-40596][CORE] Populate ExecutorDecommission with messages in ExecutorDecommissionInfo #38030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozhang2820
changed the title
|
How/where are we using the message ? |
|
Ok, so this is mainly to propagate in +CC @dongjoon-hyun |
|
Thank you, @mridulm . |
dongjoon-hyun
previously requested changes
Sep 28, 2022
Ngone51
reviewed
Sep 29, 2022
core/src/main/scala/org/apache/spark/scheduler/ExecutorLossReason.scala
Outdated
Show resolved
Hide resolved
Ngone51
reviewed
Sep 29, 2022
core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
Outdated
Show resolved
Hide resolved
|
Could you address the review comments, @bozhang2820 ? |
Sorry for the late response. I was on vacation last week. Addressed the review comments. |
|
Build passed with a retry: https://github.com/bozhang2820/spark/actions/runs/3209525689/jobs/5251496034 |
dongjoon-hyun
approved these changes
Oct 9, 2022
There was a problem hiding this comment.
Thank you for update, @bozhang2820 . It looks good to me.
What do you think about the Today's patch, @mridulm , @Ngone51 , @xuanyuanking?
|
Thanks, merged to master! |
|
Thank you all! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change populates
ExecutorDecommissionwith messages inExecutorDecommissionInfo.Why are the changes needed?
Currently the message in
ExecutorDecommissionis a fixed value ("Executor decommission."), so it is the same for all cases, e.g. spot instance interruptions and auto-scaling down. With this change we can better differentiate those cases.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added a unit test.