[SPARK-40606][PS][TEST] Eliminate to_pandas warnings in test
#38042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Sep 29, 2022
| @@ -152,7 +152,7 @@ def test_from_to_pandas(self): | |||
| data = [b"1", b"2", b"3"] | |||
| pser = pd.Series(data) | |||
| psser = ps.Series(data) | |||
| self.assert_eq(pser, psser.to_pandas()) | |||
| self.assert_eq(pser, psser._to_pandas()) | |||
There was a problem hiding this comment.
Just for my info, what is the difference in the old and new method, anything functional?
There was a problem hiding this comment.
the only difference between to_pandas() and _to_pandas() is the warning.
zhengruifeng
force-pushed
the
ps_test_to_pandas
branch
from
faf006d
to
ede09ef
Compare
|
also cc @HyukjinKwon @itholic @xinrong-meng |
HyukjinKwon
approved these changes
Sep 30, 2022
itholic
approved these changes
Sep 30, 2022
|
Merged into master, thanks all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Eliminate
to_pandaswarnings in test, by changingto_pandas()to_to_pandas()Why are the changes needed?
when a test containing
to_pandasfailed, it may print tons of warnings, for example, in https://github.com/zhengruifeng/spark/actions/runs/3142284988/jobs/5106178199it printed this warning from line 1243 to line 3985:
Does this PR introduce any user-facing change?
No
How was this patch tested?
updated tests