[SPARK-39876][FOLLOW-UP][SQL] Add parser and Dataset tests for SQL UNPIVOT #38153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan here is |
|
Can one of the admins verify this patch? |
cloud-fan
reviewed
Oct 10, 2022
Comment on lines
45
to
48
| table("t") | ||
| ) | ||
| .where(coalesce($"val").isNotNull) | ||
| .select(star()) |
There was a problem hiding this comment.
Suggested change
| table("t") | |
| ) | |
| .where(coalesce($"val").isNotNull) | |
| .select(star()) | |
| table("t")) | |
| .where(coalesce($"val").isNotNull) | |
| .select(star()) |
There was a problem hiding this comment.
Done, also added two tests regarding EXCLUDE / INCLUDE NULLS.
cloud-fan
reviewed
Oct 10, 2022
| Seq("val"), | ||
| table("t") | ||
| ) | ||
| .where(coalesce($"val").isNotNull) |
cloud-fan
approved these changes
Oct 10, 2022
|
All tests green. |
cloud-fan
approved these changes
Oct 13, 2022
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…PIVOT ### What changes were proposed in this pull request? Adds more tests for the SQL `UNPIVOT` clause. apache#37407 (comment) ### Why are the changes needed? Better test coverage. ### Does this PR introduce _any_ user-facing change? No, only more tests and fixing one issue. SQL `UNPIVOT` has not been released yet. ### How was this patch tested? In `UnpivotParserSuite` and `DatasetUnpivotSuite`. Closes apache#38153 from EnricoMi/branch-sql-unpivot-tests. Authored-by: Enrico Minack <github@enrico.minack.dev> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds more tests for the SQL
UNPIVOTclause. #37407 (comment)Why are the changes needed?
Better test coverage.
Does this PR introduce any user-facing change?
No, only more tests and fixing one issue. SQL
UNPIVOThas not been released yet.How was this patch tested?
In
UnpivotParserSuiteandDatasetUnpivotSuite.