[WIP][SPARK-40464][YARN] Support automatic data format conversion for shuffle state db #38220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… shuffle state db
LuciferYang
reviewed
Oct 12, 2022
| LOGGER.warn("Migrate DBBackend from {}({}) to {}({})", | ||
| fromDbBackend.name(), fromFile.getCanonicalPath(), | ||
| toDbBackend.name(), toFile.getCanonicalPath()); | ||
| DB fromDb = initDB(fromDbBackend, fromFile, version, mapper); |
There was a problem hiding this comment.
Should close the fromDb and toDb after used
LuciferYang
reviewed
Oct 12, 2022
| Preconditions.checkNotNull(_recoveryPath, | ||
| "recovery path should not be null if NM recovery is enabled"); | ||
|
|
||
| DBBackend registeredExecutorsDbBackend = findExistedDbBackend(RECOVERY_FILE_NAME); |
There was a problem hiding this comment.
line 503 ~ line 511 can be extract into a general method and put into the helper class
LuciferYang
reviewed
Oct 12, 2022
| @@ -493,6 +496,49 @@ protected Path getRecoveryPath(String fileName) { | |||
| return _recoveryPath; | |||
| } | |||
|
|
|||
| private void migrateRecoveryDb() throws IOException { | |||
| Preconditions.checkNotNull(_recoveryPath, | |||
There was a problem hiding this comment.
should not be a checkNotNull, I think it should be _recoveryPath
|
|
@panbingkun Any updates of this one ? |
|
Can one of the admins verify this patch? |
I will update it weekend. |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.