Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-40786][SQL][TESTS] Check error classes in PlanParserSuite #38271

Closed
wants to merge 5 commits into from

Conversation

panbingkun
Copy link
Contributor

What changes were proposed in this pull request?

This PR aims to replace 'intercept' with 'Check error classes' in PlanParserSuite.

Why are the changes needed?

The changes improve the error framework.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By running the modified test suite:

$ build/sbt "test:testOnly *PlanParserSuite"

@github-actions github-actions bot added the SQL label Oct 16, 2022
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@panbingkun
Copy link
Contributor Author

cc @MaxGekk

@MaxGekk
Copy link
Member

MaxGekk commented Oct 16, 2022

+1, LGTM. Merging to master.
Thank you, @panbingkun.

@MaxGekk MaxGekk closed this in 2aba927 Oct 16, 2022
@panbingkun panbingkun deleted the SPARK-40786 branch November 4, 2022 03:30
SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?
This PR aims to replace 'intercept' with 'Check error classes' in PlanParserSuite.

### Why are the changes needed?
The changes improve the error framework.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
By running the modified test suite:
```
$ build/sbt "test:testOnly *PlanParserSuite"
```

Closes apache#38271 from panbingkun/SPARK-40786.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants