[SPARK-40816][CONNECT][PYTHON] Rename LogicalPlan.collect to LogicalPlan.to_proto #38279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Oct 17, 2022
|
should it be a private method? |
|
If this class isn't going to be documented as an API, it's fine. |
This class is not API class so sounds like it's ok. only session, dataframe, client, readwriter (possibly catalog) will be API class I think. |
|
Can one of the admins verify this patch? |
|
also happening on this PR |
HyukjinKwon
reviewed
Oct 18, 2022
| @@ -80,9 +80,19 @@ def _verify(self, session: "RemoteSparkSession") -> bool: | |||
|
|
|||
| return test_plan == plan | |||
|
|
|||
| def collect( | |||
There was a problem hiding this comment.
Let's problably fix the error here together.
There was a problem hiding this comment.
errors should have been fixed.
HyukjinKwon
pushed a commit
that referenced
this pull request
Oct 18, 2022
### What changes were proposed in this pull request? The mypy check in master seems to be broken: <img width="676" alt="Screen Shot 2022-10-17 at 1 09 13 PM" src="https://user-images.githubusercontent.com/1938382/196273759-64372862-6caa-4a9e-b700-b665c7ff7e6c.png"> (see it on #38279 and #38275, also reproducible locally). This PR propose to remove the relevant `type: ignore` comments. ### Why are the changes needed? Fix python lint check. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes #38287 from amaliujia/test_python_lint. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
amaliujia
force-pushed
the
rename_logical_plan_collect2
branch
from
10d61a1
to
5ce1d17
Compare
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? The mypy check in master seems to be broken: <img width="676" alt="Screen Shot 2022-10-17 at 1 09 13 PM" src="https://user-images.githubusercontent.com/1938382/196273759-64372862-6caa-4a9e-b700-b665c7ff7e6c.png"> (see it on apache#38279 and apache#38275, also reproducible locally). This PR propose to remove the relevant `type: ignore` comments. ### Why are the changes needed? Fix python lint check. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38287 from amaliujia/test_python_lint. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…lan.to_proto ### What changes were proposed in this pull request? The `collect` method in `class LogicalPlan` is really to generate connect proto plan. It's confusing to use `collect` which overlaps with `collect` in dataframe API that returns materialized data. This PR proposes to rename this method to `to_proto` to match its implementation. ### Why are the changes needed? Improve codebase readability. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38279 from amaliujia/rename_logical_plan_collect2. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
collectmethod inclass LogicalPlanis really to generate connect proto plan. It's confusing to usecollectwhich overlaps withcollectin dataframe API that returns materialized data.This PR proposes to rename this method to
to_prototo match its implementation.Why are the changes needed?
Improve codebase readability.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT