[SPARK-40828][CONNECT][PYTHON][TESTING] Drop Python test tables before and after unit tests #38293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and after unit tests
|
R: @HyukjinKwon You mentioned we should drop test tables. |
amaliujia
commented
Oct 18, 2022
| @@ -74,7 +73,7 @@ def _udf_mock(cls, *args, **kwargs) -> str: | |||
| @classmethod | |||
| def setUpClass(cls: Any) -> None: | |||
| cls.connect = MockRemoteSession() | |||
| cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "") | |||
| cls.tbl_name = "test_connect_plan_only_table_1" | |||
There was a problem hiding this comment.
We do not need to drop this because this table name works with MockRemoteSession. The table has never been created.
|
Can one of the admins verify this patch? |
grundprinzip
approved these changes
Oct 18, 2022
HyukjinKwon
approved these changes
Oct 19, 2022
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…e and after unit tests ### What changes were proposed in this pull request? 1. Instead of random names, use fixed names for test tables. 2. Try to drop test tables before and after unit tests. ### Why are the changes needed? Improve python client's testing framework. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38293 from amaliujia/python_testing_cleanup_table. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Improve python client's testing framework.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT