[SPARK-40924][SQL][3.3] Fix for Unhex when input has odd number of symbols #38416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaxGekk backported, please take a look |
|
All GAs passed: |
MaxGekk
pushed a commit
that referenced
this pull request
Oct 28, 2022
…mbols ### What changes were proposed in this pull request? Fix for a bug in Unhex function when there is an odd number of symbols in the input string. This is backport of #38402 ### Why are the changes needed? Unhex function and other functions depending on it (e.g. ToBinary) produce incorrect output. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests Closes #38416 from vitaliili-db/backport33. Authored-by: Vitalii Li <vitalii.li@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
This was referenced Mar 7, 2024
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Mar 11, 2024
Summary: apache/spark#38416 fixed unhex function when input string has an odd number of characters. Pull Request resolved: #8993 Reviewed By: Yuhta Differential Revision: D54748449 Pulled By: mbasmanova fbshipit-source-id: 281985fdbdd775e347a598c018a6ce9d1b046b62
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…#8993) Summary: apache/spark#38416 fixed unhex function when input string has an odd number of characters. Pull Request resolved: facebookincubator#8993 Reviewed By: Yuhta Differential Revision: D54748449 Pulled By: mbasmanova fbshipit-source-id: 281985fdbdd775e347a598c018a6ce9d1b046b62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix for a bug in Unhex function when there is an odd number of symbols in the input string.
This is backport of #38402
Why are the changes needed?
Unhex function and other functions depending on it (e.g. ToBinary) produce incorrect output.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests