[SPARK-40967][SQL] Migrate failAnalysis() onto error classes
#38436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
failAnalysis() onto error classesfailAnalysis() onto error classes
|
@srielau @cloud-fan @itholic @panbingkun @LuciferYang Please, review this PR. |
LuciferYang
reviewed
Oct 30, 2022
| @@ -196,7 +198,8 @@ trait CheckAnalysis extends PredicateHelper with LookupCatalog { | |||
| hof.dataTypeMismatch(hof, checkRes) | |||
| case TypeCheckResult.TypeCheckFailure(message) => | |||
There was a problem hiding this comment.
Will it still match TypeCheckResult.TypeCheckFailure(message)?
There was a problem hiding this comment.
When we finish all tasks of converting the type check failures to error classes, we will remove TypeCheckResult.TypeCheckFailure(), and as a consequence of that, we can remove all match cases, and unneeded error classes like this.
So far, there are open tasks, I wouldn't do that:
- https://issues.apache.org/jira/browse/SPARK-40371
- https://issues.apache.org/jira/browse/SPARK-40372
- https://issues.apache.org/jira/browse/SPARK-40374
- https://issues.apache.org/jira/browse/SPARK-40748
- https://issues.apache.org/jira/browse/SPARK-40749
- https://issues.apache.org/jira/browse/SPARK-40769
since there is a risk to miss something.
panbingkun
approved these changes
Oct 31, 2022
cloud-fan
approved these changes
Oct 31, 2022
|
Merging to master. Thank you, @LuciferYang @panbingkun @itholic @cloud-fan for review. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? In the PR, I propose to migrate `failAnalysis()` errors onto temporary error classes with the prefix `_LEGACY_ERROR_TEMP_23xx`. The error message will not include the error classes, so, in this way we will preserve the existing behaviour. ### Why are the changes needed? The migration on temporary error classes allows to gather statistics about errors and detect most popular error classes. After that we could prioritise the work on migration. The new error class name prefix `_LEGACY_ERROR_TEMP_` proposed here kind of marks the error as developer-facing, not user-facing. Developers can still get the error class programmatically via the `SparkThrowable` interface, so that they can build error infra with it. End users won't see the error class in the message. This allows us to do the error migration very quickly, and we can refine the error classes and mark them as user-facing later (naming them properly, adding tests, etc.). ### Does this PR introduce _any_ user-facing change? No. The error messages should be almost the same by default. ### How was this patch tested? By running the affected test suites: ``` $ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite" ``` Closes apache#38436 from MaxGekk/legacy-error-class-failAnalysis. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to migrate
failAnalysis()errors onto temporary error classes with the prefix_LEGACY_ERROR_TEMP_23xx. The error message will not include the error classes, so, in this way we will preserve the existing behaviour.Why are the changes needed?
The migration on temporary error classes allows to gather statistics about errors and detect most popular error classes. After that we could prioritise the work on migration.
The new error class name prefix
_LEGACY_ERROR_TEMP_proposed here kind of marks the error as developer-facing, not user-facing. Developers can still get the error class programmatically via theSparkThrowableinterface, so that they can build error infra with it. End users won't see the error class in the message. This allows us to do the error migration very quickly, and we can refine the error classes and mark them as user-facing later (naming them properly, adding tests, etc.).Does this PR introduce any user-facing change?
No. The error messages should be almost the same by default.
How was this patch tested?
By running the affected test suites: