[SPARK-40971][CONNECT][DSL] Do not need to use proto. to refer generated classes in Connect DSL.
#38445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid calling `proto.` for Connect DSL.
|
R: @cloud-fan |
amaliujia
changed the title
proto. in Connect DSL.proto. to refer generated classes in Connect DSL.
cloud-fan
approved these changes
Oct 31, 2022
HyukjinKwon
approved these changes
Oct 31, 2022
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…rated classes in Connect DSL ### What changes were proposed in this pull request? The Connect DSL only deal with Connect proto, thus there is no need to use `proto.` to refer to those proto generates class. Instead, we can import more from the proto package to simplify the DSL code. There won't be ambiguity to class references after this change. ### Why are the changes needed? Codebase simplification. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UT Closes apache#38445 from amaliujia/clean_up_dsl. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The Connect DSL only deal with Connect proto, thus there is no need to use
proto.to refer to those proto generates class. Instead, we can import more from the proto package to simplify the DSL code. There won't be ambiguity to class references after this change.Why are the changes needed?
Codebase simplification.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT