Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark-4995] Replace Vector.toBreeze.activeIterator with foreachActive #3846

Closed
wants to merge 4 commits into from
Closed

[Spark-4995] Replace Vector.toBreeze.activeIterator with foreachActive #3846

wants to merge 4 commits into from

Conversation

james64
Copy link
Contributor

@james64 james64 commented Dec 30, 2014

New foreachActive method of vector was introduced by SPARK-4431 as more efficient alternative to vector.toBreeze.activeIterator. There are some parts of codebase where it was not yet replaced.

@dbtsai

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mengxr
Copy link
Contributor

mengxr commented Dec 30, 2014

add to whitelist

@mengxr
Copy link
Contributor

mengxr commented Dec 30, 2014

ok to test

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

Test build #24901 has started for PR 3846 at commit 3eb7e37.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 30, 2014

Test build #24901 has finished for PR 3846 at commit 3eb7e37.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24901/
Test PASSed.

@dbtsai
Copy link
Member

dbtsai commented Dec 30, 2014

LGTM

@asfgit asfgit closed this in 0f31992 Dec 30, 2014
@mengxr
Copy link
Contributor

mengxr commented Dec 30, 2014

Merged into master. Thanks!

@james64 james64 deleted the SPARK-4995-foreachActive branch December 31, 2014 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants