[SPARK-34079][SQL][FOLLOWUP] Improve the readability and simplify the code for MergeScalarSubqueries #38461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MergeScalarSubqueries
|
ping @peter-toth cc @cloud-fan |
peter-toth
reviewed
Nov 1, 2022
| Seq(newPlan, cachedPlan).map(plan => plan.aggregateExpressions.flatMap(_.collect { | ||
| case a: AggregateExpression => a | ||
| })) | ||
| val supportsHashAggregates = aggregateExprSeq.map(aggregateExpressions => |
There was a problem hiding this comment.
Thanks @beliefer for the PR. I'm ok with the changes. Only a nit that you could probably use val Seq(newPlanSupportsHashAggregates, cachedPlanSupportsHashAggregates) = ... syntax here to avoid using .head and .last.
There was a problem hiding this comment.
I feel like the previous code is more readable... Small code duplication doesn't hurt.
There was a problem hiding this comment.
@peter-toth 's suggestion could keep the readability and simplify code too.
cloud-fan
reviewed
Nov 2, 2022
Comment on lines
349
to
352
| val aggregateExpressionsSeq = | ||
| Seq(newPlan, cachedPlan).map(plan => plan.aggregateExpressions.flatMap(_.collect { | ||
| case a: AggregateExpression => a | ||
| })) |
There was a problem hiding this comment.
Suggested change
| val aggregateExpressionsSeq = | |
| Seq(newPlan, cachedPlan).map(plan => plan.aggregateExpressions.flatMap(_.collect { | |
| case a: AggregateExpression => a | |
| })) | |
| val aggregateExpressionsSeq = Seq(newPlan, cachedPlan).map { plan => | |
| plan.aggregateExpressions.flatMap(_.collect { | |
| case a: AggregateExpression => a | |
| }) | |
| } |
cloud-fan
reviewed
Nov 2, 2022
| newPlanSupportsObjectHashAggregate && cachedPlanSupportsObjectHashAggregate || | ||
| newPlanSupportsObjectHashAggregate == cachedPlanSupportsObjectHashAggregate | ||
| } | ||
| newPlanSupportsHashAggregate == cachedPlanSupportsHashAggregate && |
There was a problem hiding this comment.
we can avoid using lazy val
newPlanSupportsHashAggregate == cachedPlanSupportsHashAggregate && {
val Seq(newPlanSupportsObjectHashAggregate, cachedPlanSupportsObjectHashAggregate) = ...
...
}
|
ping @cloud-fan |
|
thanks, merging to master! |
|
@cloud-fan @peter-toth Thank you! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
… code for MergeScalarSubqueries ### What changes were proposed in this pull request? Recently, I read the `MergeScalarSubqueries` because it is a feature used for improve performance. I fount the parameters of ScalarSubqueryReference is hard to understand, so I want add some comments on it. Additionally, the private method `supportedAggregateMerge` of `MergeScalarSubqueries` looks redundant, this PR wants simplify the code. ### Why are the changes needed? Improve the readability and simplify the code for `MergeScalarSubqueries`. ### Does this PR introduce _any_ user-facing change? 'No'. Just improve the readability and simplify the code for `MergeScalarSubqueries`. ### How was this patch tested? Exists tests. Closes apache#38461 from beliefer/SPARK-34079_followup. Authored-by: Jiaan Geng <beliefer@163.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Recently, I read the
MergeScalarSubqueriesbecause it is a feature used for improve performance.I fount the parameters of ScalarSubqueryReference is hard to understand, so I want add some comments on it.
Additionally, the private method
supportedAggregateMergeofMergeScalarSubquerieslooks redundant, this PR wants simplify the code.Why are the changes needed?
Improve the readability and simplify the code for
MergeScalarSubqueries.Does this PR introduce any user-facing change?
'No'.
Just improve the readability and simplify the code for
MergeScalarSubqueries.How was this patch tested?
Exists tests.