[SPARK-41002][CONNECT][PYTHON] Compatible take, head and first API in Python client
#38488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaliujia
changed the title
take and head API in Python clienttake, head and first API in Python client
grundprinzip
approved these changes
Nov 3, 2022
| :class:`Row` | ||
| First row if :class:`DataFrame` is not empty, otherwise ``None``. | ||
| """ | ||
| return self.head() |
There was a problem hiding this comment.
maybe this is copied from PySpark, but isn't it better to signal intent here with a 1 as explicit param?
There was a problem hiding this comment.
This is implementation details though but updated to self.head(1).
There was a problem hiding this comment.
ah actually we cannot. self.head() returns Optional[Row] but self.head(n) returns List[Row]. self.head() is to make sure mypy check pass.
amaliujia
force-pushed
the
SPARK-41002
branch
from
a03a8dd
to
05afe6e
Compare
|
actually I will follow https://spark.apache.org/contributing.html. to add a short description for test cases in this PR/ |
|
Can one of the admins verify this patch? |
|
Ok added short description for the new test cases. |
|
merged into master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…API in Python client ### What changes were proposed in this pull request? 1. Add `take(n)` API. 2. Change `head(n)` API to return `Union[Optional[Row], List[Row]]`. 3. Update `first()` to return `Optional[Row]`. ### Why are the changes needed? Improve API coverage. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes apache#38488 from amaliujia/SPARK-41002. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
take(n)API.head(n)API to returnUnion[Optional[Row], List[Row]].first()to returnOptional[Row].Why are the changes needed?
Improve API coverage.
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT