[SPARK-41058][CONNECT] Remove unused import in commands.proto #38491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengziming
force-pushed
the
minor-import
branch
from
d87ebc0
to
9c10a7e
Compare
HyukjinKwon
changed the title
dengziming
force-pushed
the
minor-import
branch
from
9c10a7e
to
ded207a
Compare
|
Can one of the admins verify this patch? |
|
looks fine |
dengziming
force-pushed
the
minor-import
branch
from
ded207a
to
57ce269
Compare
|
@amaliujia can you take a look? |
|
@dengziming I have missed this PR because there was no JIRA created under https://issues.apache.org/jira/browse/SPARK-39375 (I was monitoring works happened there). Since you are doing this change, can you create a JIRA for removing unused code (then update PR title with the JIRA included) and BTW remove some other unused code in connect project? I am seeing one example at There are also unused imports probably existing that we can further clean up. |
dengziming
changed the title
dengziming
force-pushed
the
minor-import
branch
from
57ce269
to
4c35160
Compare
|
LGTM |
|
thanks, merging to master! |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? expressions.proto is not used in commands.proto ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? github CI Closes apache#38491 from dengziming/minor-import. Authored-by: dengziming <dengziming@bytedance.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
expressions.proto is not used in commands.proto
Does this PR introduce any user-facing change?
No
How was this patch tested?
github CI