[SPARK-41012][SQL] Rename _LEGACY_ERROR_TEMP_1022 to ORDER_BY_POS_OUT_OF_RANGE
#38508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
changed the title
_LEGACY_ERROR_TEMP_1022 to ORDER_BY_POS_OUT_OF_RANGE
MaxGekk
approved these changes
Nov 4, 2022
|
+1, LGTM. Merging to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…OUT_OF_RANGE` ### What changes were proposed in this pull request? This PR proposes to rename `_LEGACY_ERROR_TEMP_1022` to `ORDER_BY_POS_OUT_OF_RANGE` ### Why are the changes needed? Error class name should clear/briefly explain the error message. ### Does this PR introduce _any_ user-facing change? User-facing error class name is changed. ### How was this patch tested? ``` ./build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z order-by-ordinal.sql" ``` Closes apache#38508 from itholic/SPARK-41012. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to rename
_LEGACY_ERROR_TEMP_1022toORDER_BY_POS_OUT_OF_RANGEWhy are the changes needed?
Error class name should clear/briefly explain the error message.
Does this PR introduce any user-facing change?
User-facing error class name is changed.
How was this patch tested?