Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-41023][BUILD] Upgrade Jackson to 2.14.0 #38523

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

This pr aims upgrade Jackson related dependencies from 2.13.4 to 2.14.0.

Why are the changes needed?

After Jackson 2.14.0, all Jackson components required Java 8 except jackson-annotations, the release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

@LuciferYang LuciferYang marked this pull request as draft November 6, 2022 06:38
@github-actions github-actions bot added the BUILD label Nov 6, 2022
@bjornjorgensen
Copy link
Contributor

https://issues.apache.org/jira/browse/SPARK-40911

I think that @pjfanning will work on this one.

@pjfanning
Copy link
Contributor

@LuciferYang feel free to continue with your PR. I marked SPARK-41023 as a duplicate of SPARK-40911.

@pjfanning
Copy link
Contributor

Shouldn't guava changes be done in a separate PR?

@srowen
Copy link
Member

srowen commented Nov 6, 2022

Looks OK if tests pass. I think we need to update the two together, so this resolves both JIRAs

@LuciferYang LuciferYang marked this pull request as ready for review November 6, 2022 23:15
@LuciferYang
Copy link
Contributor Author

@srowen test passed

@LuciferYang
Copy link
Contributor Author

@LuciferYang feel free to continue with your PR. I marked SPARK-41023 as a duplicate of SPARK-40911.

Thanks ~

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Nov 6, 2022

Shouldn't guava changes be done in a separate PR?

@pjfanning Currently, I will not be considered upgrade Guava for the following reasons:

  1. Although Spark 3.4.0 will no longer release the hadoop-2 distribution, but the build and testing process is still running. We need to keep it and will not consider upgrading Guava until it is really removed

  2. In my impression, Hive 2.3 still dependency on the Guava 14.0.1, @sunchao has tried to solve this problem before, but it was not completed and I don't know whether there are any plans for follow-up.

Sorry @pjfanning , from the mail list, I found that I should @bjornjorgensen

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once there is no considerable Guava as described in #38523 (comment)

@srowen
Copy link
Member

srowen commented Nov 7, 2022

There is no Guava issue here right? just checking

@LuciferYang
Copy link
Contributor Author

Although I think the problems mentioned by @bjornjorgensen @pjfanning are not related to this pr, and the release notes do not mention the constraints of the Guava version, I will double check.

Can you clarify whether the Guava version is related to this pr? @bjornjorgensen @pjfanning

@pjfanning
Copy link
Contributor

I have no idea why @bjornjorgensen brought up gauva. The comment appears to have been deleted but I received an email notification about a comment made by @bjornjorgensen yesterday afternoon

@LuciferYang Have you tried to upgrade guava to 31.1-jre?

I can see no reason why guava should be updated as part of this PR and I said that in a previous comment on this PR after I saw the now missing comment.

@LuciferYang
Copy link
Contributor Author

I have no idea why @bjornjorgensen brought up gauva. The comment appears to have been deleted but I received an email notification about a comment made by @bjornjorgensen yesterday afternoon

@LuciferYang Have you tried to upgrade guava to 31.1-jre?

I can see no reason why guava should be updated as part of this PR and I said that in a previous comment on this PR after I saw the now missing comment.

Thanks for your reply and let us wait for @bjornjorgensen to clarify

@LuciferYang
Copy link
Contributor Author

I didn't find the coupling between Jackson 2.14.0 and Guava that Spark depends on from the dependency tree.

However, but I found that jackson-module-scala_2.13-2.14.0.jar was compiled by Scala 2.13.10

@srowen Please wait for me to do some compatibility test because Spark depends on Scala 2.13.8 and skips the upgrade of Scala 2.13.10.

@pjfanning
Copy link
Contributor

the byte code generated by Scala 2.13.10 compiler will work with any Scala 2.13.x runtime.

@LuciferYang
Copy link
Contributor Author

@pjfanning Thank you very much

@bjornjorgensen
Copy link
Contributor

@LuciferYang I apologize for asking you a question here. the guava thing was completely unrelated to this one. I therefore deleted my question, and instead asked it on the mailing list.

@LuciferYang
Copy link
Contributor Author

LuciferYang commented Nov 7, 2022

@LuciferYang I apologize for asking you a question here. the guava thing was completely unrelated to this one. I therefore deleted my question, and instead asked it on the mailing list.

Thanks for your clarification @bjornjorgensen

@srowen
Copy link
Member

srowen commented Nov 7, 2022

Merged to master

@srowen srowen closed this in eb6d198 Nov 7, 2022
@LuciferYang
Copy link
Contributor Author

SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?
This pr aims upgrade `Jackson` related dependencies from 2.13.4 to 2.14.0.

### Why are the changes needed?
After Jackson 2.14.0, all Jackson components required Java 8 except `jackson-annotations`, the release notes as follows:

- https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.14

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass GitHub Actions

Closes apache#38523 from LuciferYang/SPARK-41023.

Authored-by: yangjie01 <yangjie01@baidu.com>
Signed-off-by: Sean Owen <srowen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants