-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-41023][BUILD] Upgrade Jackson to 2.14.0 #38523
Conversation
https://issues.apache.org/jira/browse/SPARK-40911 I think that @pjfanning will work on this one. |
@LuciferYang feel free to continue with your PR. I marked SPARK-41023 as a duplicate of SPARK-40911. |
Shouldn't guava changes be done in a separate PR? |
Looks OK if tests pass. I think we need to update the two together, so this resolves both JIRAs |
@srowen test passed |
Thanks ~ |
@pjfanning Currently, I will not be considered upgrade Guava for the following reasons:
Sorry @pjfanning , from the mail list, I found that I should @bjornjorgensen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once there is no considerable Guava as described in #38523 (comment)
There is no Guava issue here right? just checking |
Although I think the problems mentioned by @bjornjorgensen @pjfanning are not related to this pr, and the release notes do not mention the constraints of the Guava version, I will double check. Can you clarify whether the Guava version is related to this pr? @bjornjorgensen @pjfanning |
I have no idea why @bjornjorgensen brought up gauva. The comment appears to have been deleted but I received an email notification about a comment made by @bjornjorgensen yesterday afternoon
I can see no reason why guava should be updated as part of this PR and I said that in a previous comment on this PR after I saw the now missing comment. |
Thanks for your reply and let us wait for @bjornjorgensen to clarify |
I didn't find the coupling between Jackson 2.14.0 and Guava that Spark depends on from the dependency tree. However, but I found that @srowen Please wait for me to do some compatibility test because Spark depends on Scala 2.13.8 and skips the upgrade of Scala 2.13.10. |
the byte code generated by Scala 2.13.10 compiler will work with any Scala 2.13.x runtime. |
@pjfanning Thank you very much |
@LuciferYang I apologize for asking you a question here. the guava thing was completely unrelated to this one. I therefore deleted my question, and instead asked it on the mailing list. |
Thanks for your clarification @bjornjorgensen |
Merged to master |
Thanks @srowen @bjornjorgensen @pjfanning @itholic |
### What changes were proposed in this pull request? This pr aims upgrade `Jackson` related dependencies from 2.13.4 to 2.14.0. ### Why are the changes needed? After Jackson 2.14.0, all Jackson components required Java 8 except `jackson-annotations`, the release notes as follows: - https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.14 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions Closes apache#38523 from LuciferYang/SPARK-41023. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Sean Owen <srowen@gmail.com>
What changes were proposed in this pull request?
This pr aims upgrade
Jackson
related dependencies from 2.13.4 to 2.14.0.Why are the changes needed?
After Jackson 2.14.0, all Jackson components required Java 8 except
jackson-annotations
, the release notes as follows:Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions