[SPARK-41061][CONNECT] Support SelectExpr which applies Projection by expressions in Strings in Connect DSL #38573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… expressions in Strings in Connect DSL.
|
R: @cloud-fan |
|
shall we add the python client API in this PR as well? |
|
@cloud-fan the python side is blocked on how to build the expression protos: https://github.com/apache/spark/blob/master/python/pyspark/sql/connect/column.py Right now there is a mixed of |
|
thanks, merging to master! |
|
I will send several PR to improve the expressions on Python side to unblock relevant API implementation. This is the first one: #38586 |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
… expressions in Strings in Connect DSL ### What changes were proposed in this pull request? 1. support `def selectExpr(exprs: String*)` in Connect DSL. 2. Server side supports translation Expressions in Strings. ### Why are the changes needed? Improve API coverage. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT Closes apache#38573 from amaliujia/select_expr_connect_dsl. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
def selectExpr(exprs: String*)in Connect DSL.Why are the changes needed?
Improve API coverage.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
UT