[SPARK-41161][BUILD] Upgrade scala-parser-combinators to 2.1.1 #38675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
reviewed
Nov 16, 2022
|
Yes, set to draft because I am still testing Scala 2.13 |
|
pass on 2.12 and 2.13 |
HyukjinKwon
approved these changes
Nov 18, 2022
|
Merged to master. |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? This pr aims upgrade `scala-parser-combinators` from 1.1.2 to 2.1.1 ### Why are the changes needed? `scala-parser-combinators` start support Scala3 after 2.0.0, all release notes after 1.1.2 as follows: - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-M1 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-M2 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-RC1 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-RC2 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.0.0 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.1.0 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.1.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GA Closes apache#38675 from LuciferYang/scala-parser-combinators-211. Lead-authored-by: YangJie <yangjie01@baidu.com> Co-authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 15, 2022
### What changes were proposed in this pull request? This pr aims upgrade `scala-parser-combinators` from 1.1.2 to 2.1.1 ### Why are the changes needed? `scala-parser-combinators` start support Scala3 after 2.0.0, all release notes after 1.1.2 as follows: - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-M1 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-M2 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-RC1 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-RC2 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.0.0 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.1.0 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.1.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GA Closes apache#38675 from LuciferYang/scala-parser-combinators-211. Lead-authored-by: YangJie <yangjie01@baidu.com> Co-authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? This pr aims upgrade `scala-parser-combinators` from 1.1.2 to 2.1.1 ### Why are the changes needed? `scala-parser-combinators` start support Scala3 after 2.0.0, all release notes after 1.1.2 as follows: - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-M1 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-M2 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-RC1 - https://github.com/scala/scala-parser-combinators/releases/tag/v1.2.0-RC2 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.0.0 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.1.0 - https://github.com/scala/scala-parser-combinators/releases/tag/v2.1.1 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GA Closes apache#38675 from LuciferYang/scala-parser-combinators-211. Lead-authored-by: YangJie <yangjie01@baidu.com> Co-authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims upgrade
scala-parser-combinatorsfrom 1.1.2 to 2.1.1Why are the changes needed?
scala-parser-combinatorsstart support Scala3 after 2.0.0, all release notes after 1.1.2 as follows:Does this PR introduce any user-facing change?
No
How was this patch tested?